Use assignments for enums in pillow #11959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamdanal
commented
May 18, 2024
| ROTATE_270: Literal[4] | ||
| TRANSPOSE: Literal[5] | ||
| TRANSVERSE: Literal[6] | ||
| FLIP_LEFT_RIGHT: Final = 0 |
Contributor
Author
There was a problem hiding this comment.
I tried to use the enum value here like this FLIP_LEFT_RIGHT: Final = Transpose.FLIP_LEFT_RIGHT.value but pytype complained.
This comment has been minimized.
This comment has been minimized.
srittau
requested changes
May 19, 2024
stubs/Pillow/PIL/DdsImagePlugin.pyi
Outdated
Comment on lines
222
to
238
| UYVY = i32(b"UYVY") | ||
| R8G8_B8G8 = i32(b"RGBG") | ||
| YUY2 = i32(b"YUY2") | ||
| G8R8_G8B8 = i32(b"GRGB") | ||
| DXT1 = i32(b"DXT1") | ||
| DXT2 = i32(b"DXT2") | ||
| DXT3 = i32(b"DXT3") | ||
| DXT4 = i32(b"DXT4") | ||
| DXT5 = i32(b"DXT5") | ||
| DX10 = i32(b"DX10") | ||
| BC4S = i32(b"BC4S") | ||
| BC4U = i32(b"BC4U") | ||
| BC5S = i32(b"BC5S") | ||
| BC5U = i32(b"BC5U") | ||
| ATI1 = i32(b"ATI1") | ||
| ATI2 = i32(b"ATI2") | ||
| MULTI2_ARGB8 = i32(b"MET1") |
Collaborator
There was a problem hiding this comment.
I wonder why none of our tests complained, but I doubt this will work. We just need to use the generated int value and possibly add a comment with the "source" value.
hamdanal
changed the title
srittau
approved these changes
May 19, 2024
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #11957 and #11956.
With this change, typeshed becomes ready for the change in the type checker behavior regarding unassigned enum attributes.
Edit: pygit2 changes have been split to a separate PR